Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup Immutable File in Cardano transaction #1825

Closed
8 tasks done
jpraynaud opened this issue Jul 15, 2024 · 0 comments · Fixed by #1838
Closed
8 tasks done

Cleanup Immutable File in Cardano transaction #1825

jpraynaud opened this issue Jul 15, 2024 · 0 comments · Fixed by #1838
Assignees
Labels
refactoring 🛠️ Code refactoring and enhancements

Comments

@jpraynaud
Copy link
Member

jpraynaud commented Jul 15, 2024

Why

We need to remove all the code related to the immutable files for the Cardano transaction which is not used anymore since we transitioned to chain sync.

What

Clean the code form the immutable files in the Cardano transaction and simplify it where possible.

How

  • Create a migration to remove the immutable file number in cardano_tx table (signer and aggregator)
  • Clean the immutable files from the cardano_block_scanner module of mithril-common
    • Remove the immutable_block_streamer sub module
    • Remove the ImmutableLowerBoundFinder
    • Remove the CardanoImmutableBlockScanner
    • Remove all the references to ImmutableFileNumber in the module
    • Remove the dir_path parameter from BlockScanner::scan
  • Clean the integration tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring 🛠️ Code refactoring and enhancements
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants