Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GitHub actions cross compiling fix #1859

Merged
merged 2 commits into from
Feb 26, 2020
Merged

GitHub actions cross compiling fix #1859

merged 2 commits into from
Feb 26, 2020

Conversation

danielSanchezQ
Copy link
Contributor

@danielSanchezQ danielSanchezQ commented Feb 26, 2020 •
edited by NicolasDP
Loading

Bring back older version of cross supporting OpenSSL in order to cross-compile properly.

This was triggered by this
It is related to #1796 although it does not fix that.

fix #1856

NicolasDP
NicolasDP approved these changes Feb 26, 2020
View reviewed changes
Copy link
Contributor

@NicolasDP NicolasDP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make Cross great again!

@NicolasDP NicolasDP added automated A-build Area: Build system A-jormungandr Area: Issues affecting jörmungandr labels Feb 26, 2020
@NicolasDP NicolasDP added this to the Net Improvement 6 milestone Feb 26, 2020
mzabaluev
mzabaluev approved these changes Feb 26, 2020
View reviewed changes
Copy link
Contributor

@mzabaluev mzabaluev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will do as a quick fix.
A proper fix would be either #1796, or getting openssl to compile and link the bundled source of the OpenSSL C library.

@NicolasDP NicolasDP merged commit 259fff0 into input-output-hk:master Feb 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mzabaluev mzabaluev mzabaluev approved these changes

@NicolasDP NicolasDP NicolasDP approved these changes

Assignees

@danielSanchezQ danielSanchezQ

Labels
A-build Area: Build system A-jormungandr Area: Issues affecting jörmungandr automated
Projects
None yet
Milestone
Net Improvement 6
Development

Successfully merging this pull request may close these issues.

aarch64-unknown-linux-gnu is missing in the release
3 participants
@danielSanchezQ @mzabaluev @NicolasDP