Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch reqwest to rustls #1796

Closed
mzabaluev opened this issue Feb 15, 2020 · 0 comments · Fixed by #1961
Closed

Switch reqwest to rustls #1796

mzabaluev opened this issue Feb 15, 2020 · 0 comments · Fixed by #1961
Labels
A-jcli Area: Command Line Interface and tooling technical debt issue to track potential technical dept we are introducing but will need care later.

Comments

@mzabaluev
Copy link
Contributor

jcli uses the reqwest crate with the default build flags, which pull in openssl-sys as part of the TLS implementation. To get rid of the dependency on libssl.so on Unix, this too needs to be switched to rustls.

A switch to the tokio 0.2 stack and reqwest 0.10 can be performed at the same time, if not prohibitively hard to do.
@mzabaluev mzabaluev added technical debt issue to track potential technical dept we are introducing but will need care later. A-jcli Area: Command Line Interface and tooling labels Feb 15, 2020
@mzabaluev mzabaluev mentioned this issue Feb 15, 2020
Closed
@danielSanchezQ danielSanchezQ mentioned this issue Feb 26, 2020
Merged
@eugene-babichenko eugene-babichenko mentioned this issue Mar 25, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-jcli Area: Command Line Interface and tooling technical debt issue to track potential technical dept we are introducing but will need care later.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

switch to rustls from openssl input-output-hk/jormungandr
1 participant
@mzabaluev