Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unhandled Data.Binary.Get error observed in node logs #1228

Closed
alan-mcnicholas opened this issue Dec 24, 2019 · 1 comment
Closed

Unhandled Data.Binary.Get error observed in node logs #1228

alan-mcnicholas opened this issue Dec 24, 2019 · 1 comment
Assignees
@KtorZ

Comments

@alan-mcnicholas
Copy link

alan-mcnicholas commented Dec 24, 2019 •
edited by KtorZ
Loading

Context

When running the latest version of Daedalus (https://buildkite.com/input-output-hk/daedalus/builds/10138) the following error message appears in the node logs.

Dec 24 16:05:27.357 INFO fetching block 8e4d2a343f3dcf9330ad9035b3e8d168e6728904262f2c434a4f8f934ec7b676, peer_address: 52.28.91.178:3000, block: 8e4d2a343f3dcf9330ad9035b3e8d168e6728904262f2c434a4f8f934ec7b676, task: init
cardano-wallet-jormungandr.exe: Data.Binary.Get.runGet at position 0: not enough bytes
CallStack (from HasCallStack):
  error, called at libraries/binary/src/Data/Binary/Get.hs:351:5 in binary-0.8.6.0:Data.Binary.Get
Information -
Version 2019.12.23
Platform Windows 10
Installation https://buildkite.com/input-output-hk/daedalus/builds/10138

Steps to Reproduce

  1. Install version of Daedalus from the link above. Note this error does not always appear however it can be forced by closing the Daedalus client.

Expected behavior

Any errors should be handled correctly.

Actual behavior

Unhandled error is output in the node logs however this does not appear to have any adverse effect on the application.

Resolution

  • Avoid raw usage of runGet in places outside of the 'Jormungandr.Binary' module. In particular:
    • DaedalusIPC on Windows
    • Jormungandr HTTP Client 'MimeUnrender'

==> #1229

QA

logs-2019-12-24T134635.0659Z.zip
@KtorZ KtorZ self-assigned this Dec 24, 2019
@KtorZ KtorZ mentioned this issue Dec 24, 2019
Merged
@rvl rvl mentioned this issue Dec 27, 2019
Merged
iohk-bors bot added a commit that referenced this issue Dec 27, 2019
@iohk-bors @rvl
Merge #1231
4316a79 
1231: Fix missing test data in windows testing bundle r=KtorZ a=rvl

Relates to #1228.

# Overview

- Adds `mock-daedalus.js` to the windows testing bundle so that the DaedalusIPC tests can run.
- Fixes a failing DaedalusIPC test case.
- Makes `mock-daedalus.js` use `child_process.disconnect()` rather than exiting and leaving behind stray processes on windows.

# Comments

[Latest build](https://hydra.iohk.io/job/Cardano/cardano-wallet-pr-1231/cardano-wallet-jormungandr-tests-win64)


Co-authored-by: Rodney Lorrimar <rodney.lorrimar@iohk.io>
@piotr-iohk
Copy link
Contributor

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@KtorZ KtorZ

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@KtorZ @alan-mcnicholas @piotr-iohk