Define and use safe 'eitherRunGet' to avoid throwing on binary decoding #1229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
bors try |
tryBuild succeeded |
rvl
reviewed
Dec 27, 2019
There was a problem hiding this comment.
Looks like this will quash the error call from runGet.
The runNodeChannel loop relies on an exception to terminate. On posix the hGet function will throw an IOError if the channel is closed. It appears that on windows, hGet returns an empty string. It may not even throw an exception. I will check that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number
#1228
Overview
ca2675b
illustrate non-safety in Jörmungandr API client binary decoders
8e87584
define and export a safe version of 'runGet'
428d0c8
use safe 'eitherRunGet' to decode API types
36d794b
move 'eitherRunGet' into its own module for re-usability
f6bec23
safely decode IPC messages on Windows using eitherRunGet
26dd771
re-generate nix machinery