Fix missing test data in windows testing bundle #1231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a sticky package interdependency that meant that isPortOpen needed to be copy&pasted into two packages. One of the copies missed a bug fix. Since the package interdependency is no longer there, delete the broken copy.
rvl
force-pushed
the
rvl/1228/windows-test-data
branch
from
2dea92e
to
c9ae233
Compare
This disconnects child_process nicely so that nodejs will not kill cardano-wallet-jormungandr. Daedalus does the same thing.
|
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
Dec 27, 2019
1231: Fix missing test data in windows testing bundle r=KtorZ a=rvl Relates to #1228. # Overview - Adds `mock-daedalus.js` to the windows testing bundle so that the DaedalusIPC tests can run. - Fixes a failing DaedalusIPC test case. - Makes `mock-daedalus.js` use `child_process.disconnect()` rather than exiting and leaving behind stray processes on windows. # Comments [Latest build](https://hydra.iohk.io/job/Cardano/cardano-wallet-pr-1231/cardano-wallet-jormungandr-tests-win64) Co-authored-by: Rodney Lorrimar <rodney.lorrimar@iohk.io>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #1228.
Overview
mock-daedalus.jsto the windows testing bundle so that the DaedalusIPC tests can run.mock-daedalus.jsusechild_process.disconnect()rather than exiting and leaving behind stray processes on windows.Comments
Latest build