Add `isort` to CI and pre-commit configuration #47

atreyasha · 2022-10-26T13:43:30Z

This PR proposes using isort in our CI and pre-commit configuration

github-actions · 2022-10-26T13:46:59Z

Coverage Report

File	Stmts	Miss	Cover	Missing
parser.py	0	0	100%
privacy_glue.py	0	0	100%
reading_comprehension.py	0	5	58%	9, 12, 15, 18, 21
sequence_classification.py	0	5	58%	9, 12, 15, 18, 21
sequence_tagging.py	0	5	58%	9, 12, 15, 18, 21
tasks
opp_115.py	0	0	100%
piextract.py	0	0	100%
policy_detection.py	0	0	100%
policy_ie_a.py	0	0	100%
policy_ie_b.py	0	0	100%
policy_qa.py	0	0	100%
privacy_qa.py	0	0	100%
utils
experiment_utils.py	0	1	97%	21
logging_utils.py	0	0	100%
parser_utils.py	0	0	100%
pipeline_utils.py	0	0	100%
TOTAL	419	16	96%

Tests	Skipped	Failures	Errors	Time
237	0 💤	0 ❌	0 🔥	7.051s ⏱️

github-actions · 2022-10-26T13:51:35Z

Coverage Report

File	Stmts	Miss	Cover	Missing
parser.py	0	0	100%
privacy_glue.py	0	0	100%
reading_comprehension.py	0	5	58%	9, 12, 15, 18, 21
sequence_classification.py	0	5	58%	9, 12, 15, 18, 21
sequence_tagging.py	0	5	58%	9, 12, 15, 18, 21
tasks
opp_115.py	0	0	100%
piextract.py	0	0	100%
policy_detection.py	0	0	100%
policy_ie_a.py	0	0	100%
policy_ie_b.py	0	0	100%
policy_qa.py	0	0	100%
privacy_qa.py	0	0	100%
utils
experiment_utils.py	0	1	97%	23
logging_utils.py	0	0	100%
parser_utils.py	0	0	100%
pipeline_utils.py	0	0	100%
TOTAL	419	16	96%

Tests	Skipped	Failures	Errors	Time
237	0 💤	0 ❌	0 🔥	6.291s ⏱️

github-actions · 2022-10-26T14:01:46Z

Coverage Report

File	Stmts	Miss	Cover	Missing
parser.py	0	0	100%
privacy_glue.py	0	0	100%
reading_comprehension.py	0	5	58%	9, 12, 15, 18, 21
sequence_classification.py	0	5	58%	9, 12, 15, 18, 21
sequence_tagging.py	0	5	58%	9, 12, 15, 18, 21
tasks
opp_115.py	0	0	100%
piextract.py	0	0	100%
policy_detection.py	0	0	100%
policy_ie_a.py	0	0	100%
policy_ie_b.py	0	0	100%
policy_qa.py	0	0	100%
privacy_qa.py	0	0	100%
utils
experiment_utils.py	0	1	97%	23
logging_utils.py	0	0	100%
parser_utils.py	0	0	100%
pipeline_utils.py	0	0	100%
TOTAL	419	16	96%

Tests	Skipped	Failures	Errors	Time
237	0 💤	0 ❌	0 🔥	5.511s ⏱️

Add `isort` in checks

Add `isort` to static action

github-actions · 2022-10-27T07:36:35Z

Coverage Report

File	Stmts	Miss	Cover	Missing
parser.py	0	0	100%
privacy_glue.py	0	0	100%
reading_comprehension.py	0	5	58%	9, 12, 15, 18, 21
sequence_classification.py	0	5	58%	9, 12, 15, 18, 21
sequence_tagging.py	0	5	58%	9, 12, 15, 18, 21
tasks
opp_115.py	0	0	100%
piextract.py	0	0	100%
policy_detection.py	0	0	100%
policy_ie_a.py	0	0	100%
policy_ie_b.py	0	0	100%
policy_qa.py	0	0	100%
privacy_qa.py	0	0	100%
utils
experiment_utils.py	0	1	97%	23
logging_utils.py	0	0	100%
parser_utils.py	0	0	100%
pipeline_utils.py	0	0	100%
TOTAL	419	16	96%

Tests	Skipped	Failures	Errors	Time
237	0 💤	0 ❌	0 🔥	9.280s ⏱️

atreyasha requested a review from Christof93 October 26, 2022 13:50

atreyasha linked an issue Oct 26, 2022 that may be closed by this pull request

Add import sorting to static code analysis #31

Closed

atreyasha force-pushed the as/isort branch from e21d08c to bd579a4 Compare October 26, 2022 14:00

atreyasha added 5 commits October 27, 2022 09:34

Update pyproject.toml with isort configuration

8e044ae

Update python dependencies with isort

b07c7b6

Update pre-commit configuration

f2cbc9c

Add `isort` in checks

Update GitHub workflow for static action

7354f82

Add `isort` to static action

Run isort on all files

b25916d

atreyasha force-pushed the as/isort branch from bd579a4 to b25916d Compare October 27, 2022 07:35

Christof93 approved these changes Oct 27, 2022

View reviewed changes

atreyasha merged commit ae2e894 into main Oct 27, 2022

atreyasha deleted the as/isort branch October 27, 2022 17:36

Provide feedback