Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add query all channels command #570

Merged
merged 2 commits into from
Jan 28, 2021
Merged

Add query all channels command #570

merged 2 commits into from
Jan 28, 2021

Conversation

ancazamfir
Copy link
Collaborator

Closes: #568

Description


For contributor use:

  • Updated the Unreleased section of CHANGELOG.md with the issue.
  • If applicable: Unit tests written, added test to CI.
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Updated relevant documentation (docs/) and code comments.
  • Re-reviewed Files changed in the Github PR explorer.

@codecov-io
Copy link

Codecov Report

Merging #570 (aed5ac7) into master (b1b37f5) will increase coverage by 32.4%.
The diff coverage is 67.4%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #570      +/-   ##
=========================================
+ Coverage    13.6%   46.1%   +32.4%     
=========================================
  Files          69     139      +70     
  Lines        3752    9218    +5466     
  Branches     1374       0    -1374     
=========================================
+ Hits          513    4251    +3738     
- Misses       2618    4967    +2349     
+ Partials      621       0     -621     
Impacted Files Coverage Δ
...application/ics20_fungible_token_transfer/error.rs 0.0% <0.0%> (ø)
...pplication/ics20_fungible_token_transfer/events.rs 0.0% <ø> (ø)
...ion/ics20_fungible_token_transfer/msgs/transfer.rs 0.0% <0.0%> (ø)
modules/src/events.rs 0.0% <0.0%> (ø)
modules/src/ics02_client/error.rs 100.0% <ø> (ø)
modules/src/ics02_client/raw.rs 0.0% <0.0%> (ø)
modules/src/ics03_connection/error.rs 100.0% <ø> (+66.6%) ⬆️
modules/src/ics03_connection/msgs/conn_open_try.rs 86.7% <ø> (ø)
modules/src/ics03_connection/version.rs 97.6% <ø> (ø)
modules/src/ics04_channel/channel.rs 77.2% <ø> (+62.1%) ⬆️
... and 260 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4425648...aed5ac7. Read the comment docs.

Copy link
Member

@adizere adizere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

// TODO - tendermint deps should not be here
use tendermint::account::Id as AccountId;
use tendermint::block::Height;
use tendermint_proto::Protobuf;
use tokio::runtime::Runtime as TokioRuntime;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI: There may be conflicts here if we merge #565 before this PR.

@ancazamfir ancazamfir merged commit 2f88aa4 into master Jan 28, 2021
@ancazamfir ancazamfir deleted the anca/query_channels branch January 28, 2021 11:05
hu55a1n1 pushed a commit to hu55a1n1/hermes that referenced this pull request Sep 13, 2022
* Add query all channels command

* Update Changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add CLI to query all channels on a given chain
3 participants