-
Notifications
You must be signed in to change notification settings - Fork 326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added CLI to query for all connections #565
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Just one small comment, will leave it up to you.
@@ -44,3 +44,15 @@ impl From<ConnectionIds> for RawClientConnections { | |||
} | |||
} | |||
} | |||
|
|||
impl FromIterator<ConnectionId> for ConnectionIds { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Haven't noticed this file before. Why is it called raw.rs
and part of the ics02_client
? Its content relates to connections. It would be nice to move this to ics03_connection
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file was added during one of the first queries, query client connections
I think in #169.
The RawClientConnections
connections and ConnectionIds
are the main types in this file. It's not really clear to me at this point where it would be best to place these types.
I'll move the file to ICS03, which I agree is a better place than ICS02. But still this file contains a raw/proto type, which is the weirdest part that should be solved; I propose we refactor this and move stuff around as necessary in https://github.com/informalsystems/ibc-rs/issues/425.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
RawClientConnections
is defined locally, not part of any protofbuf. And it is not what the name suggests, it's just a vector of String
-s. I'm not sure we need it at all to be honest. If we keep it, ics03 is the best place. I will take care of cleaning it in the next PR.
One more thing, could you optimize imports on the changed files? |
Codecov Report
@@ Coverage Diff @@
## master informalsystems/hermes#565 +/- ##
=========================================
+ Coverage 13.6% 45.5% +31.8%
=========================================
Files 69 142 +73
Lines 3752 9355 +5603
Branches 1374 0 -1374
=========================================
+ Hits 513 4261 +3748
- Misses 2618 5094 +2476
+ Partials 621 0 -621
Continue to review full report at Codecov.
|
* Added query for informalsystems#553 and upd changelog. * Moved the 'raw' ConnectionIds file from ICS02 to ICS03 * Optimized imports à la intellij * Cargo fmt Co-authored-by: Anca Zamfir <zamfiranca@gmail.com>
Closes: #553
Example output:
For contributor use:
docs/
) and code comments.Files changed
in the Github PR explorer.