Process write acknowledgements on packet_callback
#2439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DaviRain-Su
requested review from
hu55a1n1,
plafer and
ancazamfir
as code owners
hu55a1n1
requested changes
Jul 21, 2022
There was a problem hiding this comment.
Thanks for the great work @DaviRain-Su! 🙌 I added some comments, eg. handling failed acks.
romac
changed the title
packet_callback
|
This also needs a changelog entry. |
hu55a1n1
reviewed
Jul 22, 2022
hu55a1n1
added a commit
to hu55a1n1/hermes
that referenced
this pull request
Sep 13, 2022
…2439) * add write_acknowledgement process on packet_callback * fix bug * extract write_ack logic to process_write_ack function * add issue #2424 and 2438 to changelog * Derive From/Into for opaque Ack * Use generic Ack as writeAck input * Simplify Ack trait * Process write ack using conversion to generic Ack * Allow `packet_callback()` to emit IbcEvents Co-authored-by: hu55a1n1 <sufialhussaini@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: https://github.com/informalsystems/ibc-rs/issues/2424
Closes: https://github.com/informalsystems/ibc-rs/issues/2428
Description
Add Write_Acknowledgement Process on Packet_Callback.
PR author checklist:
unclog.docs/).Reviewer checklist:
Files changedin the GitHub PR explorer.