Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

About the use of WriteAcknowledgement #36

Closed
5 tasks
DaviRain-Su opened this issue Jul 19, 2022 · 3 comments
Closed
5 tasks

About the use of WriteAcknowledgement #36

DaviRain-Su opened this issue Jul 19, 2022 · 3 comments
Labels
A: bug Admin: something isn't working

Comments

@DaviRain-Su
Copy link
Contributor

DaviRain-Su commented Jul 19, 2022

I found the handling of writeAcknowledgement in the read spec, and it seems that there is no handling of writeAknowledgement in ibc-rs

Summary of Bug


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate milestone (priority) applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@hu55a1n1
Copy link
Contributor

Nice catch @DaviRain-Su! ibc-rs indeed does not handle the synchronous case for writeAcknowledgement. 👍
I think the best place to implement this would be in the crate::core::ics04_channel::handler::packet_callback after these lines (similar to how ibc-go does it) -> https://github.com/informalsystems/ibc-rs/blob/a189902e6f1d726e22bfe394134dba44a2e0f653/modules/src/core/ics04_channel/handler.rs#L209-L213
Here's a related issue -> https://github.com/informalsystems/ibc-rs/issues/1525
Would you like to take a stab at fixing this? Happy to help review and merge it. Otherwise will fix this before the next release.

@hu55a1n1 hu55a1n1 added the A: bug Admin: something isn't working label Jul 19, 2022
@hu55a1n1
Copy link
Contributor

Related issue/bug -> #35.

@DaviRain-Su
Copy link
Contributor Author

DaviRain-Su commented Jul 20, 2022

Here's a related issue -> https://github.com/informalsystems/ibc-rs/issues/1525
Would you like to take a stab at fixing this? Happy to help review and merge it. Otherwise will fix this before the next release.

Based on your feedback I made an attempt to modify

hu55a1n1 referenced this issue in informalsystems/hermes Jul 26, 2022
* add write_acknowledgement process on packet_callback

* fix bug

* extract write_ack logic to process_write_ack function

* add issue #2424 and 2438 to changelog

* Derive From/Into for opaque Ack

* Use generic Ack as writeAck input

* Simplify Ack trait

* Process write ack using conversion to generic Ack

* Allow `packet_callback()` to emit IbcEvents

Co-authored-by: hu55a1n1 <sufialhussaini@gmail.com>
hu55a1n1 referenced this issue in hu55a1n1/hermes Sep 13, 2022
…2439)

* add write_acknowledgement process on packet_callback

* fix bug

* extract write_ack logic to process_write_ack function

* add issue #2424 and 2438 to changelog

* Derive From/Into for opaque Ack

* Use generic Ack as writeAck input

* Simplify Ack trait

* Process write ack using conversion to generic Ack

* Allow `packet_callback()` to emit IbcEvents

Co-authored-by: hu55a1n1 <sufialhussaini@gmail.com>
@hu55a1n1 hu55a1n1 transferred this issue from informalsystems/hermes Sep 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: bug Admin: something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants