Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2686 - ids-dropdown listbox fix display of 0-value #2821

Merged
merged 5 commits into from
Sep 12, 2024

Conversation

clayinfor
Copy link
Collaborator

@clayinfor clayinfor commented Sep 11, 2024

Explain the details for making this change. What existing problem does the pull request solve?

Fixed a bug where 0-indexed values were not being properly displayed in ids-dropdown.

Related github/jira issue (required):

Closes #2686
Related examples: infor-design/enterprise-wc-examples#98

Steps necessary to review your pull request (required):

  1. Check out this branch and run: nvm i && nvm use && npm i && npm run start
  2. Test Dropdown with 0-index value dropdown at the bottom of here: http://localhost:4300/ids-dropdown/example.html
  3. Ensure no regressions here: http://localhost:4300/ids-multiselect/example.html
  4. In another terminal window, and run npm run publish:link
  5. Then check out this branch in enterprise-wc-examples: 2686 - ids-dropdown listbox fix display of 0-value enterprise-wc-examples#98
  6. Then run: npm i && npm link ids-enterprise-wc
  7. Then run: rm -fr .angular/cache && nvm i && nvm use && npm run build && npm run start
  8. Then see IDS Dropdown 0-indexed examples here: http://localhost:4200/ids-reactive-forms/example
  9. Keep clicking the Update Values button and ensure new dropdown cycles through each option without ever skipping the first 0-indexed value.
  10. Also ensure the IDS Multiselect field cycles through each option properly.

Included in this Pull Request:

  • Some documentation for the feature.
  • A test for the bug or feature.
  • A note to the change log.

@clayinfor clayinfor requested a review from a team as a code owner September 11, 2024 09:42
Copy link
Contributor

@n-ace-ancog n-ace-ancog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working on my side.

Base:

Screen.Recording.2024-09-12.at.5.16.02.PM.mov

Angular:

Screen.Recording.2024-09-12.at.5.18.35.PM.mov
Screen.Recording.2024-09-12.at.5.17.47.PM.mov

@tmcconechy tmcconechy merged commit bd219a1 into main Sep 12, 2024
4 checks passed
@tmcconechy tmcconechy deleted the 2686-dropdown-listbox-display-0-value branch September 12, 2024 15:17
@jbrcna
Copy link
Contributor

jbrcna commented Sep 13, 2024

Large GIF (542x636)

the issue still exist
Large GIF (542x636)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IdsDropdown/IdsListBox: Issue with selecting & displaying the value at index 0
5 participants