Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2686 - ids-dropdown listbox fix display of 0-value #98

Merged
merged 1 commit into from
Sep 11, 2024

Conversation

clayinfor
Copy link
Contributor

@clayinfor clayinfor commented Sep 11, 2024

Explain the details for making this change. What existing problem does the pull request solve?

Add example to test this ticket which points out a bug where 0-indexed values are not being properly displayed in ids-dropdown.

Related github/jira issue(s) (required):

Related: infor-design/enterprise-wc#2686
Main PR: infor-design/enterprise-wc#2821

Steps necessary to review your pull request (required):

  1. Check out branch 2686-dropdown-listbox-display-0-value from this repository: https://github.com/infor-design/enterprise-wc-examples
  2. Then run: npm install
  3. Then run: rm -fr .angular/cache && nvm i && nvm use && npm run build && npm run start
  4. Then see IDS Dropdown 0-indexed examples here: http://localhost:4200/ids-reactive-forms/example
  5. Keep clicking the Update Values button and ensure new dropdown cycles through each option without ever skipping the first 0-indexed value.

Included in this Pull Request:

@tmcconechy tmcconechy merged commit a9fcd2f into main Sep 11, 2024
@tmcconechy tmcconechy deleted the 2686-dropdown-listbox-display-0-value branch September 11, 2024 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants