This restores the old time range behavior #8771
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsternberg
force-pushed
the
js-restore-old-timerange-behavior
branch
2 times, most recently
from
6addea9 to
3cd7007
Compare
jsternberg
requested review from
rbetts and
benbjohnson
and removed request for
rbetts
benbjohnson
suggested changes
Sep 1, 2017
query/compile_test.go
Outdated
| @@ -145,7 +145,7 @@ func TestCompile_Failures(t *testing.T) { | |||
| {s: `SELECT bottom(value, 2.5) FROM cpu`, err: `expected integer as last argument in bottom(), found 2.500`}, | |||
| {s: `SELECT bottom(value, -1) FROM cpu`, err: `limit (-1) in bottom function must be at least 1`}, | |||
| {s: `SELECT bottom(value, 3) FROM cpu LIMIT 2`, err: `limit (3) in bottom function can not be larger than the LIMIT (2) in the select statement`}, | |||
| {s: `SELECT value FROM cpu WHERE time >= now() - 10m OR time < now() - 5m`, err: `cannot use OR with time conditions`}, | |||
| //{s: `SELECT value FROM cpu WHERE time >= now() - 10m OR time < now() - 5m`, err: `cannot use OR with time conditions`}, | |||
There was a problem hiding this comment.
Can you either remove this line or add a comment about why it's commented out?
All time ranges are combined with AND regardless of context and regardless of whether it makes any logical sense. That was the previous behavior and, unfortunately, a lot of people rely on it.
jsternberg
force-pushed
the
js-restore-old-timerange-behavior
branch
from
3cd7007 to
c8440b4
Compare
benbjohnson
approved these changes
Sep 14, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All time ranges are combined with AND regardless of context and
regardless of whether it makes any logical sense.
That was the previous behavior and, unfortunately, a lot of people rely
on it.
This change modifies the changelog for #8712.