Remove TimeRange function and replace with a more accurate ConditionExpr function #8712
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsternberg
force-pushed
the
js-enhance-condition-parsing
branch
from
38e9265 to
435ed07
Compare
benbjohnson
approved these changes
Aug 16, 2017
|
lgtm but needs a rebase with master to update the |
…xpr function The ConditionExpr function is more accurate because it parses the condition and ensures that time conditions are actually used correctly. That means that attempting to combine conditions with OR will not result in the query silently pretending it's an AND and nested conditions work correctly so there is only one way to read the query. It also extracts the non-time conditions into a separate condition so we can stop attempting to parse around the time conditions in lower layers of the storage engine. This change does not remove those hacks, but a following commit should be able to sanitize the condition and remove them.
jsternberg
force-pushed
the
js-enhance-condition-parsing
branch
from
435ed07 to
6977596
Compare
This was referenced Aug 30, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ConditionExpr function is more accurate because it parses the condition
and ensures that time conditions are actually used correctly. That means
that attempting to combine conditions with OR will not result in the query
silently pretending it's an AND and nested conditions work correctly so
there is only one way to read the query.
It also extracts the non-time conditions into a separate condition so we
can stop attempting to parse around the time conditions in lower layers of
the storage engine. This change does not remove those hacks, but a
following commit should be able to sanitize the condition and remove them.