Make services/{admin, httpd, subscriber, udp} golintable

CHANGELOG.md

@@ -36,6 +36,7 @@
 - [#8171](https://github.com/influxdata/influxdb/issues/8171): Significantly improve shutdown speed for high cardinality databases.
 - [#8177](https://github.com/influxdata/influxdb/issues/8177): Fix racy integration test.
 - [#8230](https://github.com/influxdata/influxdb/issues/8230): Prevent overflowing or underflowing during window computation.
+- [#8058](https://github.com/influxdata/influxdb/pull/8058): Enabled golint for admin, httpd, subscriber, udp. @karlding
 
 ## v1.2.2 [2017-03-14]
 

services/admin/service.go

@@ -81,6 +81,7 @@ func (s *Service) Close() error {
 	return nil
 }
 
+// WithLogger sets the logger for the service
 func (s *Service) WithLogger(log zap.Logger) {
 	s.logger = log.With(zap.String("service", "admin"))
 }

services/httpd/response_writer.go

@@ -118,11 +118,11 @@ func (w *csvFormatter) WriteResponse(resp Response) (n int, err error) {
 					return n, err
 				}
 
-				if out, err := io.WriteString(w, "\n"); err != nil {
+				out, err := io.WriteString(w, "\n")
+				if err != nil {
 					return n, err
-				} else {
-					n += out
 				}
+				n += out
 			}
 			w.statementID = result.StatementID
 

services/subscriber/http.go

@@ -22,7 +22,7 @@ func NewHTTP(addr string, timeout time.Duration) (*HTTP, error) {
 
 // NewHTTPS returns a new HTTPS points writer with default options and HTTPS configured.
 func NewHTTPS(addr string, timeout time.Duration, unsafeSsl bool, caCerts string) (*HTTP, error) {
-	tlsConfig, err := createTlsConfig(caCerts)
+	tlsConfig, err := createTLSConfig(caCerts)
 	if err != nil {
 		return nil, err
 	}
@@ -54,7 +54,7 @@ func (h *HTTP) WritePoints(p *coordinator.WritePointsRequest) (err error) {
 	return
 }
 
-func createTlsConfig(caCerts string) (*tls.Config, error) {
+func createTLSConfig(caCerts string) (*tls.Config, error) {
 	if caCerts == "" {
 		return nil, nil
 	}

services/udp/service.go

@@ -19,8 +19,8 @@ const (
 	// Arbitrary, testing indicated that this doesn't typically get over 10
 	parserChanLen = 1000
 
-	// MAX_UDP_PAYLOAD is largest payload size the UDP service will accept.
-	MAX_UDP_PAYLOAD = 64 * 1024
+	// MaxUDPPayload is largest payload size the UDP service will accept.
+	MaxUDPPayload = 64 * 1024
 )
 
 // statistics gathered by the UDP package.
@@ -179,7 +179,7 @@ func (s *Service) writer() {
 func (s *Service) serve() {
 	defer s.wg.Done()
 
-	buf := make([]byte, MAX_UDP_PAYLOAD)
+	buf := make([]byte, MaxUDPPayload)
 	s.batcher.Start()
 	for {
 		select {