Make services/{admin, httpd, subscriber, udp} golintable #8058
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make changes to:
services/admin
admin/service.go:84:1: exported method Service.WithLogger should have comment or be unexported
services/httpd
response_writer.go:123:12: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary)
services/subscriber
subscriber/http.go:57:6: func createTlsConfig should be createTLSConfig
services/udp
service.go:23:2: don't use ALL_CAPS in Go names; use CamelCase
Required for all non-trivial PRs