Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix panic when parsing ms durations #7316

Merged
merged 1 commit into from
Sep 16, 2016
Merged

Fix panic when parsing ms durations #7316

merged 1 commit into from
Sep 16, 2016
+2 −1

Conversation

jwilder
Copy link
Contributor

@jwilder jwilder commented Sep 16, 2016 •
edited
Loading

Required for all non-trivial PRs
  • Rebased/mergable
  • Tests pass

A query such as SELECT count(value) FROM cpu GROUP BY time(500ms) will panic the parser. This only occurs if the amount for the duration literal is greater than 1 and is ms.

@corylanou @jsternberg

@jwilder jwilder added this to the 1.1.0 milestone Sep 16, 2016
@jwilder jwilder added panic area/influxql Issues related to InfluxQL query language labels Sep 16, 2016
@jsternberg
Copy link
Contributor

Should this go into 1.0.1?

@jwilder
Copy link
Contributor Author

jwilder commented Sep 16, 2016

Regression is from #7296 which is only in master (~ 2 days ago)

@jwilder jwilder merged commit e2b38f6 into master Sep 16, 2016
@jwilder jwilder deleted the jw-duration-parse-panic branch September 16, 2016 15:00
@corylanou corylanou mentioned this pull request Sep 16, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsternberg jsternberg jsternberg approved these changes

Assignees
No one assigned
Labels
area/influxql Issues related to InfluxQL query language panic
Projects
None yet
Milestone
1.1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@jwilder @jsternberg