Return appropriate error if overflowing duration when parsing #7296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
corylanou
force-pushed
the
cjl-2762
branch
2 times, most recently
from
9ce3222 to
2adb9ab
Compare
|
👍 |
| @@ -18,6 +18,8 @@ | |||
| - [#7177](https://github.com/influxdata/influxdb/issues/7177): Fix base64 encoding issue with /debug/vars stats. | |||
| - [#7196](https://github.com/influxdata/influxdb/issues/7196): Fix mmap dereferencing, fixes #7183, #7180 | |||
| - [#7013](https://github.com/influxdata/influxdb/issues/7013): Fix the dollar sign so it properly handles reserved keywords. | |||
| - [#7196](https://github.com/influxdata/influxdb/ssues/7196): Fix mmap dereferencing, fixes #7183, #7180 | |||
| - [#2792](https://github.com/influxdata/influxdb/ssues/2792): Exceeding max retention policy duration gives incorrect error message | |||
There was a problem hiding this comment.
I fixed this typo in a PR so be careful not to reintroduce it when you rebase. You also have ssues instead of issues here.
There was a problem hiding this comment.
fixed, nice catch.
corylanou
force-pushed
the
cjl-2762
branch
3 times, most recently
from
13238a8 to
9fedcfc
Compare
This was referenced Sep 16, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required for all non-trivial PRs
fixes #2762