Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant code the from response formatter and fix CloseNotify #7163

Merged
merged 2 commits into from
Aug 17, 2016

Commits on Aug 16, 2016

  1. Remove redundant code the from response formatter and fix CloseNotify

    The query killing functionality depends on the ResponseWriter exposing a
    CloseNotify method. Since we wrap the http.ResponseWriter, the new
    struct does not have that method and the HTTP handler would skip past
    calling that method.
    
    Instead of duplicating `Flush()` and `CloseNotify()` for every response
    formatter, we will unify all of that under a single struct and create
    formatters instead.
    
    Also, fixes a bug where the header information from a query would not be
    returned until some other data was returned with it because of
    buffering and another bug in the gzipResponseWriter that wouldn't flush
    the actual underlying ResponseWriter.
    jsternberg committed Aug 16, 2016
    Configuration menu
    Copy the full SHA
    71b5476 View commit details
    Browse the repository at this point in the history

Commits on Aug 17, 2016

  1. The number of bytes recorded when using chunking was off by one

    Previously, we implicitly added a newline and had to add one to the
    number of bytes transmitted because we added that byte. That was removed
    at some point and the metric was not updated to record the correct
    value.
    jsternberg committed Aug 17, 2016
    Configuration menu
    Copy the full SHA
    d2746ee View commit details
    Browse the repository at this point in the history