Remove redundant code the from response formatter and fix CloseNotify #7163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jsternberg, thanks for your PR! By analyzing the annotation information on this pull request, we identified @e-dard, @gunnaraasen and @joelegasse to be potential reviewers |
jsternberg
force-pushed
the
js-close-notify-fix
branch
2 times, most recently
from
5fe0102
to
0375954
Compare
The query killing functionality depends on the ResponseWriter exposing a CloseNotify method. Since we wrap the http.ResponseWriter, the new struct does not have that method and the HTTP handler would skip past calling that method. Instead of duplicating `Flush()` and `CloseNotify()` for every response formatter, we will unify all of that under a single struct and create formatters instead. Also, fixes a bug where the header information from a query would not be returned until some other data was returned with it because of buffering and another bug in the gzipResponseWriter that wouldn't flush the actual underlying ResponseWriter.
jsternberg
force-pushed
the
js-close-notify-fix
branch
from
0375954
to
71b5476
Compare
|
@joelegasse Can you take a look? |
Previously, we implicitly added a newline and had to add one to the number of bytes transmitted because we added that byte. That was removed at some point and the metric was not updated to record the correct value.
|
I also added a trailing commit to this to fix the statistic for query response bytes. We used to add an extra newline so a piece of code added one to that byte. That newline got moved to a new section of the code, but the addition wasn't removed so it accounted for that added newline twice instead of just once. I performed one query and retrieved the number of bytes it returned and then used |
|
LGTM 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The query killing functionality depends on the ResponseWriter exposing a
CloseNotify method. Since we wrap the http.ResponseWriter, the new
struct does not have that method and the HTTP handler would skip past
calling that method.
Instead of duplicating
Flush()andCloseNotify()for every responseformatter, we will unify all of that under a single struct and create
formatters instead.
Also, fixes a bug where the header information from a query would not be
returned until some other data was returned with it because of
buffering and another bug in the gzipResponseWriter that wouldn't flush
the actual underlying ResponseWriter.