tsdb: prevent fields with empty names being written by SELECT INTO #5713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…atements Currently, if one tries to run a SELECT INTO statement with a query whose result set has an empty column names influx will panic (influxdata#5644) or enter an infinite loop (influxdata#5712). An example of a query which causes this problem is select count(value)/60 into cpu_hour from cpu group by time(1h) It doesn't seem sane to create points with fields containing empty names, so for now, return an error rather doing something we know is going to cause a problem down the track. A better alternative might be to assign/generate default names to such columns. Signed-off-b: Jon Seymour <jon@wildducktheories.com>
|
Fails with merge conflict. Will create fix for 0.10.0 and a separate branch for merging with master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, if one tries to run a SELECT INTO statement with a query whose
result set has an empty column names influx will panic (#5644, #5697) or enter an
infinite loop (#5712).
An example of a query which causes this problem is
It doesn't seem sane to create points with fields containing empty names,
so for now, return an error rather doing something we know is going
to cause a problem down the track.
A better alternative might be to assign/generate default names to such columns.
Signed-off-b: Jon Seymour jon@wildducktheories.com