Fixes #5664 #5697
Fixes #5664 #5697
Conversation
|
👍 |
|
@e-dard See the test case in #5712. I have actually encountered this in a live system. I was getting a panic prior to apply a version of #5697. After I applied #5697 the system went into an infinite loop. Reading the code, I discovered newFieldsFromBinary doesn't handle the empty field name case. I am going to dig into why my system is trying to use a field with an empty field name. |
|
Ok, I found the problem that is resulting in an empty field name which is then generating the panic &/or loop. If I run this query: select count(value) into "summary" from "foobar" where time > now() - 1h group by time(5m) everything works as expected - a new series is created which has a "count" field. However, if I do this: select count(value)/60 into "summary" from "foobar" where time > now() - 1h group by time(5m) then I trigger either the panic or the infinite loop depending on which version of the code I have installed. In other words, the empty field name results from using math in the select clause of a SELECT INTO statement. |
Prior to influxdata#5697 it causes a panic, after influxdata#5697 it causes an infinite loop Signed-off-by: Jon Seymour <jon@wildducktheories.com>
|
Ok, I combined the test in #5712 with a fix for the problem demonstrated by that test into #5716 and have withdrawn #5712. There is a related PR #5714 which fixes a problem that causes binary points to be created with empty field names. Both PRs currently merge cleanly with 0.10.0. #5714 will need a merge conflict to be resolved before it is ready for master. |
Previously, influx would either panic (influxdata#5664) or enter a loop (post-influxdata#5697) in the case that a binary point contained an empty field name. Now we tolerate the case by skipping the empty field. Signed-off-by: Jon Seymour <jon@wildducktheories.com>
Note that this series also includes cherry-pick of influxdata#5697. Signed-off-by: Jon Seymour <jon@wildducktheories.com>
|
Closed in favour of #5716 |
This fixes the panic in #5664.