Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Results to Response (#2050) #2137

Merged
merged 2 commits into from
Apr 4, 2015
Merged

Refactor Results to Response (#2050) #2137

merged 2 commits into from
Apr 4, 2015

Conversation

peekeri
Copy link
Contributor

@peekeri peekeri commented Apr 1, 2015

As described by @pauldix in #2050, refactor client.Results and influxdb.Results struct to client.Response and influxdb.Response, respectively. This is purely change in the name of those two structs plus minor changes in comments + variable names in order to be in line with the type name change.

Testing performed:

$ go test ./...
ok      github.com/influxdb/influxdb    3.990s
ok      github.com/influxdb/influxdb/admin  0.018s
ok      github.com/influxdb/influxdb/client 0.013s
ok      github.com/influxdb/influxdb/cmd/influx 0.012s
ok      github.com/influxdb/influxdb/cmd/influxd    72.731s
ok      github.com/influxdb/influxdb/collectd   0.016s
ok      github.com/influxdb/influxdb/graphite   0.009s
ok      github.com/influxdb/influxdb/httpd  1.380s
ok      github.com/influxdb/influxdb/influxql   0.019s
ok      github.com/influxdb/influxdb/messaging  5.602s
ok      github.com/influxdb/influxdb/raft   7.339s
?       github.com/influxdb/influxdb/statik [no test files]
?       github.com/influxdb/influxdb/test   [no test files]
?       github.com/influxdb/influxdb/tests/urlgen   [no test files]
?       github.com/influxdb/influxdb/udp    [no test files]
?       github.com/influxdb/influxdb/uuid   [no test files]

@toddboom
Copy link
Contributor

toddboom commented Apr 3, 2015

@peekeri would you mind rebasing this on master so that we can merge?
@pauldix can you review this?

peekeri added 2 commits April 4, 2015 11:43
@peekeri
client: rename client.Results type to client.Response (issue: influxd…
a56ea6f 
…ata#2050)

Rename client.Results to client.Response as it already has Results
property itself. Renaming it to Response makes code look much less
ugly.
@peekeri
server: rename influxdb.Results type to influxdb.Response (issue: inf…
7046914 
…luxdata#2050)

Rename influxdb.Results to influxdb.Response as it already has Results
property itself. Renaming it to Response makes code look much less
ugly.
@peekeri
Copy link
Contributor Author

peekeri commented Apr 4, 2015

@toddboom rebased on master.

@pauldix
Copy link
Member

pauldix commented Apr 4, 2015

Yep, looks good. Thanks @peekeri!

pauldix added a commit that referenced this pull request Apr 4, 2015
@pauldix
Merge pull request #2137 from peekeri/influx-2050
fb52703 
Refactor Results to Response (#2050)
@pauldix pauldix merged commit fb52703 into influxdata:master Apr 4, 2015
@pauldix pauldix mentioned this pull request Apr 4, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@peekeri @toddboom @pauldix