Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Results to Response #2050

Closed
pauldix opened this issue Mar 22, 2015 · 1 comment
Closed

Refactor Results to Response #2050

pauldix opened this issue Mar 22, 2015 · 1 comment
Milestone
0.9.0

Comments

@pauldix
Copy link
Member

pauldix commented Mar 22, 2015

The client library and code that marshals query responses uses an object called Results. This should actually be a Response object. Having it be results is weird because it has a property called Results which are the results for each statement in the query.

Please to refactor, this is ugly
@pauldix pauldix added this to the 0.9.0 milestone Mar 22, 2015
@peekeri peekeri mentioned this issue Apr 1, 2015
Merged
peekeri added a commit to peekeri/influxdb that referenced this issue Apr 4, 2015
@peekeri
client: rename client.Results type to client.Response (issue: influxd…
a56ea6f 
…ata#2050)

Rename client.Results to client.Response as it already has Results
property itself. Renaming it to Response makes code look much less
ugly.
peekeri added a commit to peekeri/influxdb that referenced this issue Apr 4, 2015
@peekeri
server: rename influxdb.Results type to influxdb.Response (issue: inf…
7046914 
…luxdata#2050)

Rename influxdb.Results to influxdb.Response as it already has Results
property itself. Renaming it to Response makes code look much less
ugly.
pauldix added a commit that referenced this issue Apr 4, 2015
@pauldix
Merge pull request #2137 from peekeri/influx-2050
fb52703 
Refactor Results to Response (#2050)
@pauldix
Copy link
Member Author

pauldix commented Apr 4, 2015

Fixed in #2137

@pauldix pauldix closed this as completed Apr 4, 2015
mark-rushakoff pushed a commit that referenced this issue Jan 11, 2019
fix(http): Fix developer mode default
941e752 
Developer mode is now passed to assets
closes #2050
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.9.0
Development

No branches or pull requests
1 participant
@pauldix