Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(c#, java): change type of PermissionResource.type to String #45

Merged
merged 4 commits into from
Feb 23, 2022
Merged

feat(c#, java): change type of PermissionResource.type to String #45

merged 4 commits into from
Feb 23, 2022

Conversation

bednar
Copy link
Collaborator

@bednar bednar commented Feb 21, 2022 •
edited
Loading

Related to influxdata/influxdb-client-java#303
Related to influxdata/influxdb-client-csharp#290

Proposed Changes

  1. Changed type of PermissionResource.type to String for C# and Java

Checklist

  • Rebased/mergeable
  • Commit messages are in semantic format
  • Sign CLA (if not already signed)

@bednar bednar requested a review from rhajek February 21, 2022 11:41
@bednar bednar marked this pull request as ready for review February 21, 2022 11:41
@rhajek
Copy link
Contributor

rhajek commented Feb 22, 2022

@bednar there are two checks check-generated-csharp and check-generated-java that needs to be fixed, can we safely push this ?

@bednar bednar merged commit 7d3f063 into master Feb 23, 2022
@bednar bednar deleted the permission_resource_type_as_string branch February 23, 2022 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhajek rhajek rhajek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bednar @rhajek