Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: change type of PermissionResource.type to String to avoid exception for non-existing item #303

Merged
merged 4 commits into from
Feb 22, 2022
Merged

fix: change type of PermissionResource.type to String to avoid exception for non-existing item #303

merged 4 commits into from
Feb 22, 2022

Conversation

bednar
Copy link
Contributor

@bednar bednar commented Feb 21, 2022 •
edited
Loading

Proposed Changes

The PermissionResource.type is not constant value and can evolve as the API of InfluxDB changing.

=>

Change type of PermissionResource.type to String.

Checklist

  • CHANGELOG.md updated
  • Rebased/mergeable
  • A test has been added if appropriate
  • mvn test completes successfully
  • Commit messages are in semantic format
  • Sign CLA (if not already signed)

@bednar bednar marked this pull request as ready for review February 21, 2022 10:23
@bednar bednar requested a review from rhajek February 21, 2022 10:23
@bednar bednar mentioned this pull request Feb 21, 2022
Merged
3 tasks
rhajek
rhajek approved these changes Feb 21, 2022
View reviewed changes
Copy link
Contributor

@rhajek rhajek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bednar bednar merged commit 0306299 into master Feb 22, 2022
@bednar bednar deleted the permission_resource_type_as_string branch February 22, 2022 14:36
@bednar bednar added this to the 4.4.0 milestone Feb 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhajek rhajek rhajek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
5.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@bednar @rhajek