feat: Pass timeout to read and write queries

[nikoladsp]

Closes #

Proposed Changes

Request timeout is passed to read and write calls. Not sure if this is the way you would implement it, but we really needed those so thought to share our current implementation in case you find it useful.

Kindest regards

[bednar]

Hi @nikoladsp,

thanks for your PR. The issue with passing timeout to HTTP requests was resolved in a Milestone 1.17.0 by #222. Or am I missing something?

Regards

[nikoladsp]

Hi,
during the debug I did not see timeout settings were actually applied to the HTTP call, so while calling longer operations, we got timeouts.

Client is instantiated with:

url = "http://localhost:8086"
token = "MyToken"
org = "MyOrg"
timeout = 60000
cli = InfluxDBClient(url=url, token=token, org=org, timeout=timeout)

So when in for example influxdb_client/service/write_service.py in code

return self.api_client.call_api(
            '/api/v2/write', 'POST',
            path_params,
            query_params,
            header_params,
            body=body_params,
            post_params=form_params,
            files=local_var_files,
            response_type=None,  # noqa: E501
            auth_settings=auth_settings,
            async_req=local_var_params.get('async_req'),
            _return_http_data_only=local_var_params.get('_return_http_data_only'),  # noqa: E501
            _preload_content=local_var_params.get('_preload_content', True),
            _request_timeout=local_var_params.get('_request_timeout'),
            collection_formats=collection_formats,
            urlopen_kw=urlopen_kw)

_request_timeout was set to None, so we used the patch in subject.

Maybe we did something wrong?

Thanks

[bednar]

The request timeout is set in lower API. Try to add breakpoint here:

influxdb-client-python/influxdb_client/rest.py

Line 159 in d465dda

_configured_timeout = _request_timeout or self.configuration.timeout

[nikoladsp]

If I set timeout in InfluxDBClient constructor, should not be passed to the actual self.api_client.call_api call?

Regards

[bednar]

It is not necessary because it is set in underlaying API:

influxdb-client-python/influxdb_client/rest.py

Line 159 in d465dda

_configured_timeout = _request_timeout or self.configuration.timeout

Which version of client do you use?

[nikoladsp]

We tried 1.17.0

[bednar]

The version 1.17.0 contains fix for passing timeout, see - #221

[nikoladsp]

Does this applies only to connection timeout or also when reading/writing?

Thanks

[bednar]

This combines the connect and read timeouts into one. You can also specify timeout as tuple: (25000, 10000) to configure connection and read timeouts differently.

• https://urllib3.readthedocs.io/en/latest/reference/urllib3.util.html?#urllib3.util.Timeout
• 

[nikoladsp]

Many thanks.

In that case we must have some strange issue in our code. I will try to investigate one more time.

Best regards

[bednar]

Hi @nikoladsp,

did you solve the problem with timeout?

Regards

[bednar]

This PR has been closed because it has not had recent activity. Please reopen if this PR is still important to you and you want to continue with them.