Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pass configured timeout to HTTP client #222

Merged
merged 2 commits into from
Apr 9, 2021
Merged

Conversation

bednar
Copy link
Contributor

@bednar bednar commented Apr 8, 2021

Closes #221

Proposed Changes

Correctly pass configured timeout into urllib3.

Checklist

  • CHANGELOG.md updated
  • Rebased/mergeable
  • pytest tests completes successfully
  • Commit messages are in semantic format
  • Sign CLA (if not already signed)

@codecov
Copy link

codecov bot commented Apr 8, 2021

Codecov Report

Merging #222 (f504d0b) into master (2870071) will increase coverage by 0.10%.
The diff coverage is 87.50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #222      +/-   ##
==========================================
+ Coverage   90.64%   90.75%   +0.10%     
==========================================
  Files          26       26              
  Lines        2010     2012       +2     
==========================================
+ Hits         1822     1826       +4     
+ Misses        188      186       -2     
Impacted Files Coverage Δ
influxdb_client/rest.py 83.45% <80.00%> (+1.64%) ⬆️
influxdb_client/client/influxdb_client.py 99.27% <100.00%> (ø)
influxdb_client/configuration.py 84.44% <100.00%> (+0.17%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2870071...f504d0b. Read the comment docs.

@bednar bednar requested a review from rhajek April 8, 2021 13:08
@bednar bednar marked this pull request as ready for review April 8, 2021 13:08
@bednar bednar merged commit d465dda into master Apr 9, 2021
@bednar bednar deleted the fix/pass-timeout branch April 9, 2021 08:20
@bednar bednar added this to the 1.17.0 milestone Apr 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No request timeout causing points not being written to influxdb
2 participants