-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: use generic PSR-18 as an HTTP
client
#129
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
bednar
changed the title
refactor: use generic PSR-7 as a
refactor: use generic PSR-18 as a Sep 5, 2022
HTTP
clientHTTP
client
bednar
changed the title
refactor: use generic PSR-18 as a
refactor: use generic PSR-18 as an Sep 5, 2022
HTTP
clientHTTP
client
Codecov Report
@@ Coverage Diff @@
## master #129 +/- ##
============================================
- Coverage 80.92% 74.67% -6.26%
- Complexity 412 421 +9
============================================
Files 24 25 +1
Lines 1012 1082 +70
============================================
- Hits 819 808 -11
- Misses 193 274 +81
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
6 tasks
bednar
requested review from
rhajek and
michaelahojna
and removed request for
rhajek
September 7, 2022 09:56
michaelahojna
approved these changes
Sep 19, 2022
3 tasks
peynman
pushed a commit
to peynman/influxdb-client-php
that referenced
this pull request
Mar 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #120
Closes #130
Proposed Changes
Uses https://www.php-fig.org/psr/psr-18/ as a
HTTP
client instead strong depends toGuzzle
:This PR drops strong couple to Guzzle HTTP client.
Now the user is able to use any implementation of
PSR-18
compliant HTTP client - https://packagist.org/providers/psr/http-client-implementation.The client has to be installed together with HTTP client:
Update InfluxDB API to latest version:
This PR also uses a new version of InfluxDB OSS API definitions - oss.yml. The following breaking changes are in underlying API services and doesn't affect common apis such as -
WriteApi
,QueryApi
,HealthApi
, ...ConfigService
to retrieve InfluxDB's runtime configurationDebugService
to retrieve debug and performance data from runtimeMetricsService
to deal with exposed prometheus metricsRemoteConnectionsService
to deal with registered remote InfluxDB connectionsResourcesService
to manage InfluxDB resourcesReplicationService
to manage InfluxDB replicationsReplicationService
to manage InfluxDB replicationsTemplatesService
to deal withStack
andTemplate
APIRestoreService
to deal with new restore functions of InfluxDBBreaking Changes
GuzzleHttp\Message\FutureResponse
DocumentService
in favour of InfluxDB Community Templates. For more info see - influxdb#19300, openapi#192DefaultSerive
:PostSignin
operation is moved toSigninService
PostSignout
operation is moved toSignoutService
Checklist
make test
completes successfully