Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Depend on PSR-18 instead of Guzzle. #120

Closed
tarjei opened this issue Apr 6, 2022 · 3 comments · Fixed by #129
Closed

Depend on PSR-18 instead of Guzzle. #120

tarjei opened this issue Apr 6, 2022 · 3 comments · Fixed by #129
Labels
enhancement New feature or request
Milestone

Comments

@tarjei
Copy link

tarjei commented Apr 6, 2022

Proposal:
When working on projects that use many different external APIs, depending on a concrete version of one http library can become a problem. It would help a lot if influx-client-php could depend on PSR-18 instead so that the concrete version of the library could vary more.

Current behavior:
Today the library depends on a given Guzzle version.

Desired behavior:
The guzzle dependencies switched to depending on http/common instead. See Mailguns PHP lib for an example.

Use case:
When working on projects that use many different external APIs, depending on a concrete version of one http library can become a problem. We are still running Guzzle 6.x and may have to do busywork just to use influxdb-client-php.

@bednar
Copy link
Contributor

bednar commented Apr 6, 2022

Hi @tarjei,

thanks for using our client.

Is this something you might be willing to help with?

Regards

@bednar bednar added the enhancement New feature or request label Apr 6, 2022
@tarjei
Copy link
Author

tarjei commented Apr 6, 2022

@bednar I'm sorry, but not at the moment no :)

@bednar
Copy link
Contributor

bednar commented Sep 6, 2022

Hi @tarjei,

We are preparing a new major version of the client (v3.0.0) which add supports for custom HTTP clients. Please try the preview version by:

composer require influxdata/influxdb-client-php:generic-http-client

For more info about new major version see:

Regards

@bednar bednar added this to the 2.10.0 milestone Sep 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants