Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update kapacitor alert rules to accept inside and outside range #729

Merged
merged 1 commit into from
Jan 5, 2017

Conversation

goller
Copy link
Contributor

@goller goller commented Jan 5, 2017

  • CHANGELOG.md updated
  • Rebased/mergable
  • Tests pass
  • Sign CLA (if not already signed)

Connect #706
Connect #707
Connect #725

The problem

No way to specify if kapacitor alert needed to be out of a range.

The Solution

Simplified the API to allow is inside range and is outside range as kapacitor operators.
If using these two operators, then, the rangeValue parameter is checked.

I updated the swagger documentation in this PR as well.

@imogenkinsman
Copy link
Contributor

Looks good.

@goller goller merged commit d63ecdf into master Jan 5, 2017
@goller goller deleted the feature/go-inside-outside-range branch January 5, 2017 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants