WIP Feature/out of range#707 #725
Conversation
| @@ -143,9 +143,9 @@ type TriggerValues struct { | |||
| Period string `json:"period,omitempty"` // Period length of time before deadman is alerted | |||
| Shift string `json:"shift,omitempty"` // Shift is the amount of time to look into the past for the alert to compare to the present | |||
| Operator string `json:"operator,omitempty"` // Operator for alert comparison | |||
| RangeOperator string `json:"range_operator,omitempty"` // RangeOperator is an optional operator for range comparisons | |||
| RangeOperator string `json:"rangeOperator,omitempty"` // RangeOperator is an optional operator for range comparisons | |||
There was a problem hiding this comment.
Oh also, would you update the documentation in server/swagger.json with the new names?
There was a problem hiding this comment.
Good catch about the go_fmt. Is the swagger.json hand-edited? I don't recall how to view and work with it.
| @@ -23,6 +26,7 @@ | |||
| } | |||
| }, | |||
| "devDependencies": { | |||
| "@kadira/storybook": "^2.21.0", | |||
There was a problem hiding this comment.
Would you update the LICENSE_OF_DEPENDENCIES.md?
There was a problem hiding this comment.
Is this auto-generated?
There was a problem hiding this comment.
Thankfully, it looks like I remembered to check in my script to do it: etc/licenses.sh ... although it looks like the Go licenses are not generated correctly from that script. Anyway, the javascript licenses use this:
nlf -c |awk -F, '{printf "%s %s \[%s\]\(%s\)\n", $1, $2, $5, $4}'
| "name": "kapa", | ||
| "url": "http://chronograf.influxcloud.net:9092", | ||
| "username": "hunter", | ||
| "password": "TMnN5JyM35H9m6Hc", |
There was a problem hiding this comment.
Is this a real password? Probably shouldn't be checked in.
There was a problem hiding this comment.
Haha, wow... My bad. That was absolutely my password.
I'll get that changed right away. I'm not sure how to change it though?
I guess I wasn't expecting that to be kept plaintext in memory on the frontend? Is there any reason for that?
…on. Also… Add a nifty corsless proxy courtesy of yt.
…d defaults to rule stub so there aren’t misses. It’s not a real object, but it reduces distracting errors.
121watts
force-pushed
the
feature/out-of-range#707
branch
from
e0f5a40 to
cb5e3ed
Compare
…out-of-range#707 # Conflicts: # chronograf.go
| Period string `json:"period,omitempty"` // Period length of time before deadman is alerted | ||
| Shift string `json:"shift,omitempty"` // Shift is the amount of time to look into the past for the alert to compare to the present | ||
| Operator string `json:"operator,omitempty"` // Operator for alert comparison | ||
| RangeOperator string `json:"rangeOperator,omitempty"` // RangeOperator is an optional operator for range comparisons |
There was a problem hiding this comment.
RangeOperator is no longer needed (merge issue)
Connect #707
Connect #711
The problem
Nothing in the GUI or backend for 'out of range' functionality in Chronograf.
The Solution
Add it!
Note
Should probably hold off merging this until the backend work is done for this.
Picture's worth some words:
