[#102] Allow proplist headers #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Isn't there any docs or examples that require changing? In the README, maybe? |
|
I've updated the README file. |
| @@ -627,7 +627,7 @@ manage_chunk(IsFin, StreamRef, Data, | |||
| NewState. | |||
|
|
|||
| %% @private | |||
| -spec process_options(map(), map(), http_verb()) -> map(). | |||
| -spec process_options(map(), headers(), http_verb()) -> map(). | |||
| process_options(Options, HeadersMap, HttpVerb) -> | |||
There was a problem hiding this comment.
It would be good to change the name of the HeadersMap variable as well to just Headers.
tothlac
force-pushed
the
headers_as_proplists
branch
from
195060f to
e017d1f
Compare
tothlac
force-pushed
the
headers_as_proplists
branch
from
e017d1f to
9107845
Compare
jfacorro
added a commit
that referenced
this pull request
Dec 18, 2015
[#102] Allow proplist headers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.