Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support headers as proplists #125

Closed
davoclavo opened this issue Nov 30, 2015 · 3 comments
Closed

Support headers as proplists #125

davoclavo opened this issue Nov 30, 2015 · 3 comments

Comments

@davoclavo
Copy link

Currently shotgun expects headers as a map: #{binary => binary}, I guess it should also support proplists [{binary, charlist}] pairs, as it is the way gun expects headers: https://github.com/ninenines/gun/blob/master/doc/src/guide/http.asciidoc#get-and-head
@davoclavo davoclavo mentioned this issue Dec 2, 2015
Open
@jfacorro jfacorro mentioned this issue Dec 9, 2015
Closed
@jfacorro
Copy link
Contributor

Closed by #133

@davoclavo
Copy link
Author

Awesome! Just for reference, I think you meant #133

@jfacorro
Copy link
Contributor

@davecaos Yeah, that's what I meant 😄. Just fixed it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@davoclavo @jfacorro