Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Registration form on lightbox appearance #60

Closed
ghost opened this issue Mar 20, 2015 · 4 comments
Closed

Registration form on lightbox appearance #60

ghost opened this issue Mar 20, 2015 · 4 comments
Assignees

Comments

@ghost
Copy link

ghost commented Mar 20, 2015

The password confirmation field looks a bit off when the registration form is displayed in the lightbox popup form. Perhaps putting each input on their own line would solve this.

pass confirm error

@DevinWalker DevinWalker self-assigned this Apr 29, 2015
@DevinWalker DevinWalker added this to the 1.0 Stable Release milestone Apr 29, 2015
@ibndawood
Copy link
Contributor

Hello @DevinWalker, Can I make the 3 columns in individual rows and submit a PR ?

@DevinWalker
Copy link
Member

@ibndawood can you make it responsive so they are only 3-column within the modal or at that width which is displayed in the screenshot showing the label bump to 2 lines? That would be awesome.

@mathetos
Copy link
Member

mathetos commented Jun 5, 2015

@ibndawood Devin and I would like to chat with you in detail. Can I get your email address? Or simply email me at matt@givewp.com Thanks!

@ibndawood
Copy link
Contributor

Hello @mathetos , I have sent you an email. Looking forward to your discussion.

pluginmirror-worker pushed a commit to wp-plugins/give that referenced this issue Jul 14, 2015
* New: Donors overview page that provides a searchable list of your donors and relevant information
* New: Initial PHPunit testing in place for post types, script and style loading, and includes
* New: Travis-CI and Scrutinizer added to GitHub repo master branch to improve integrations and code quality @see badges now https://github.com/WordImpress/Give/
* New: Updated CMB2 to latest stable version 2.0.8
* Fix: Microdata added twice to titles impress-org/givewp#154
* Fix: Divi theme compatibility improvements impress-org/givewp#157 and impress-org/givewp#156
* Fix: Login screen refreshes when user logs in during checkout process @see: https://wordpress.org/support/topic/login-on-form?replies=1#post-7060862 and impress-org/givewp#155
* Fix: Translation files need "give-" prepended to them to work properly @see: impress-org/givewp#161
* Fix: Fix PHP notice for Undefined index: _give_price. closes #159 @see: impress-org/givewp#159 - Thanks @helgatheviking!
* Fix: Shortcode now outputs Goals properly @see: https://wordpress.org/support/topic/goal-tracking
* Improvement: Script loading now properly registers scripts and styles globally using wp_register_style & wp_register_script
* Improvement: Removed numerous uses of the $give_options global - still more cleanup needed
* Improvement: Modal window CSS fixes for login fields: impress-org/givewp#60


git-svn-id: https://plugins.svn.wordpress.org/give/trunk@1198939 b8457f37-d9ea-0310-8a92-e5e31aec5664
DevinWalker pushed a commit that referenced this issue Jul 18, 2017
jonwaldstein added a commit to jonwaldstein/givewp that referenced this issue Aug 15, 2023
* refactor: move rest endpoints into new file

* refactor: move form creation action into CreateFormRoute

* refactor: move rest of inline routes into seperate fiels

* feature: create resource controller and move form builder callback logic

* refactor: use GiveWP EnqueueScript helper and cleanup localized data

* feature: create FormBuilderViewModel and implement

* docs: update docblocks

* format: reformat controller file

* feature: add basic validation to controller requests with matching feature tests

* feature: add VO for rest route config

* refactor: updat rest url with VO

* tests: add HasMockForm trait

* tests: use HasMockForm in controller test

* feature: add basic validation to render page callback

* refactor: accept formId for storage data array

* test: add test for viewModel storageData

* refactor: simplify config without enu

Co-authored-by: Jon Waldstein <jonwaldstein@jons-air.mynetworksettings.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants