Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translations don't seem to take #161

Closed
mathetos opened this issue Jul 2, 2015 · 1 comment
Closed

Translations don't seem to take #161

mathetos opened this issue Jul 2, 2015 · 1 comment
Assignees

Comments

@mathetos
Copy link
Member

mathetos commented Jul 2, 2015

A user contacted me about translating into Spanish. He couldn't get his first couple translations to appear in the plugin correctly. He sent me his files, I checked them in Poedit, then tested locally both with his translation files and with our Brazilian Portugese files and neither appeared on the front-end of the dev site at all. Here's his screencast:

http://www.screencast.com/t/Zir13kiaksp

I took a look at load_textdomain() and it seems all fine, so I'm a bit stumped.

@DevinWalker
Copy link
Member

Ok so the translation files need "give-" prepended to it. I've prepended it for our Brazilian Portuguese and it's working well. I'd love to get spanish too!

Closed with 2ffa17e

@DevinWalker DevinWalker added this to the 1.0 Stable Release milestone Jul 8, 2015
pluginmirror-worker pushed a commit to wp-plugins/give that referenced this issue Jul 14, 2015
* New: Donors overview page that provides a searchable list of your donors and relevant information
* New: Initial PHPunit testing in place for post types, script and style loading, and includes
* New: Travis-CI and Scrutinizer added to GitHub repo master branch to improve integrations and code quality @see badges now https://github.com/WordImpress/Give/
* New: Updated CMB2 to latest stable version 2.0.8
* Fix: Microdata added twice to titles impress-org/givewp#154
* Fix: Divi theme compatibility improvements impress-org/givewp#157 and impress-org/givewp#156
* Fix: Login screen refreshes when user logs in during checkout process @see: https://wordpress.org/support/topic/login-on-form?replies=1#post-7060862 and impress-org/givewp#155
* Fix: Translation files need "give-" prepended to them to work properly @see: impress-org/givewp#161
* Fix: Fix PHP notice for Undefined index: _give_price. closes #159 @see: impress-org/givewp#159 - Thanks @helgatheviking!
* Fix: Shortcode now outputs Goals properly @see: https://wordpress.org/support/topic/goal-tracking
* Improvement: Script loading now properly registers scripts and styles globally using wp_register_style & wp_register_script
* Improvement: Removed numerous uses of the $give_options global - still more cleanup needed
* Improvement: Modal window CSS fixes for login fields: impress-org/givewp#60


git-svn-id: https://plugins.svn.wordpress.org/give/trunk@1198939 b8457f37-d9ea-0310-8a92-e5e31aec5664
jonwaldstein pushed a commit to jonwaldstein/givewp that referenced this issue Aug 15, 2023
Changes to the copy for readability and to get to brand standards
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants