Remove some feature gates #367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } else { | ||
| return Err(::image::ImageError::UnsupportedError(format!( | ||
| "{:?} with {:?} bits per sample is unsupported", self.bits_per_sample, self.photometric_interpretation | ||
| ))) // TODO: this is bad we should not fail at this point} | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
Is it possible to rewrite this as a match?
PhotometricInterpretation::RGB if self.bits_per_sample == [8, 8, 8, 8] => ...
it is super unintuitive like this
|
Great |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remaining features:
core: 154 compilation errors when I remove this one. Probably fixable, but that's a lot of work.std_misc: several small things. Probably fixable too but I don't have time right now.step_by: feature-gated function because added recently. Need to check what the plan is for this one. If it's not getting stable, it is possible to write a replacement.rustc_private: used for theflatelibrary. There is a replacementflate2on crates.io, however it's just bindings for miniz.c, which would force users to have a C compiler installed. I don't like this. Probably the most problematic feature.test: not sure how to have access to the bencher without this one.