Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop relying on implementation defined structure layout. #365

Merged
merged 1 commit into from
Apr 4, 2015

Conversation

nwin
Copy link
Contributor

@nwin nwin commented Apr 3, 2015

Rust does not make any guarantees about how tuple structs are layed out in memory. Using C-type-structs mediates this potential future problem.

@nwin nwin changed the title Stop relying implementation defined structure layout. Stop relying on implementation defined structure layout. Apr 3, 2015
@nwin nwin closed this Apr 3, 2015
@nwin nwin reopened this Apr 3, 2015
@nwin
Copy link
Contributor Author

nwin commented Apr 3, 2015

Please do not merge wait for #367. That is more important.

Rust does not make any guarantees about how tuple structs are layed out in memory. Using C-type-structs mediates this potential problem.
nwin added a commit that referenced this pull request Apr 4, 2015
Stop relying on implementation defined structure layout.
@nwin nwin merged commit 09185ca into image-rs:master Apr 4, 2015
@nwin nwin deleted the fix-color branch April 4, 2015 09:09
fintelia added a commit that referenced this pull request Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant