Use nbclient instead in ixmp.testing.run_notebook() #371
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
run_notebook()
used the built-in Pythonsubprocess
module to run tutorial and test notebooks, write the results to a file, and then read the finished notebook. This process recently began to cause test & CI failures, e.g. in #370.The Jupyter ecosystem now has a first-class package
nbclient
that executes notebooks programmatically; this PR:nbformat
withnbclient
as a requirement for the 'tests' extra set. (nbclient
itself depends onnbformat
.)ci/
directory, it was not being detected by the Codecov CLI tool.How to review
PR checklist
Add or expand tests.N/AUpdate release notes.N/A