Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ixmp.jar and dependencies #370

Merged
merged 3 commits into from
Sep 21, 2020
Merged

Update ixmp.jar and dependencies #370

merged 3 commits into from
Sep 21, 2020

Conversation

fonfon
Copy link
Contributor

@fonfon fonfon commented Sep 14, 2020

Update the ixmp.jar and the java dependencies.

How to review

It'd be good to check that functionality related to the dependencies, like the r bindings or running on various platforms, works.
The test_tutorials.py tests are failing - this has to be clarified before merging (thus the draft state). update With #371 being merged the r-tests pass now, thanks Paul!

PR checklist

  • Add or expand tests.
  • Add, expand, or update documentation.
  • Update release notes.

@codecov
Copy link

codecov bot commented Sep 14, 2020

Codecov Report

Merging #370 into master will not change coverage.
The diff coverage is 100.0%.

@@          Coverage Diff           @@
##           master    #370   +/-   ##
======================================
  Coverage    96.8%   96.8%           
======================================
  Files          46      46           
  Lines        5253    5253           
======================================
  Hits         5086    5086           
  Misses        167     167           
Impacted Files Coverage Δ
ixmp/tests/core/test_meta.py 100.0% <100.0%> (ø)

@khaeru
Copy link
Member

khaeru commented Sep 15, 2020

The test_tutorials.py tests are failing

I investigated and fixed this in #371. Please rebase this branch and confirm that checks pass.

@fonfon fonfon marked this pull request as ready for review September 18, 2020 07:47
@fonfon fonfon requested a review from khaeru September 18, 2020 07:48
Copy link
Member

@khaeru khaeru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @fonfon!

@khaeru khaeru merged commit 09b7292 into master Sep 21, 2020
@khaeru khaeru deleted the feature/dependency-update branch September 21, 2020 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants