Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: switch dockerfile to go 1.23 #4517

Merged
merged 1 commit into from
Feb 19, 2025
Merged

build: switch dockerfile to go 1.23 #4517

merged 1 commit into from
Feb 19, 2025

Conversation

julienrbrt
Copy link
Member

Closes: #4516

This will be reverted in #4509

@julienrbrt julienrbrt added the skip-changelog Don't check changelog for new entries label Feb 18, 2025
@github-actions github-actions bot added component:ci CI/CD workflow and automated jobs. component:configs labels Feb 18, 2025
laciferin2024
laciferin2024 suggested changes Feb 18, 2025
View reviewed changes
Copy link

@laciferin2024 laciferin2024 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that we have 1.24.0 released. lets support it

@julienrbrt
Copy link
Member Author

Now that we have 1.24.0 released. lets support it

No, that's the reason the action wasn't working, because it was using 1.24.
This is why I mentioned this in the PR description:

This will be reverted in #4509

@laciferin2024
Copy link

The CI is failing

laciferin2024
laciferin2024 approved these changes Feb 19, 2025
View reviewed changes
Copy link

@laciferin2024 laciferin2024 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM , minor changes. But do recommend you to give a go mod tidy

@julienrbrt
Copy link
Member Author

LGTM , minor changes. But do recommend you to give a go mod tidy

There is no go mod tidy required for a dockerfile 😉

@julienrbrt julienrbrt merged commit 5bbc1a1 into main Feb 19, 2025
44 of 47 checks passed
@julienrbrt julienrbrt deleted the julien/fix-latest-docker branch February 19, 2025 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pantani Pantani Pantani approved these changes

@laciferin2024 laciferin2024 laciferin2024 approved these changes

@ilgooz ilgooz Awaiting requested review from ilgooz ilgooz is a code owner

@jeronimoalbi jeronimoalbi Awaiting requested review from jeronimoalbi jeronimoalbi is a code owner

Assignees

@julienrbrt julienrbrt

Labels
component:ci CI/CD workflow and automated jobs. component:configs skip-changelog Don't check changelog for new entries
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

FIX: github workflow for sonic
3 participants
@julienrbrt @laciferin2024 @Pantani