Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build(deps): bump to go 1.24 #4509

Draft
wants to merge 13 commits into
base: main
Choose a base branch
from
Draft

build(deps): bump to go 1.24 #4509

wants to merge 13 commits into from

Conversation

julienrbrt
Copy link
Member

@julienrbrt julienrbrt commented Feb 14, 2025 •
edited
Loading

Bump cli + app to Go 1.24 and use the new tool pattern: https://go.dev/doc/modules/managing-dependencies#tools

@github-actions github-actions bot added component:ci CI/CD workflow and automated jobs. component:configs type:internal labels Feb 14, 2025
@julienrbrt julienrbrt added the skip-changelog Don't check changelog for new entries label Feb 14, 2025
@julienrbrt
Copy link
Member Author

Super weird, looks like the library used by json library <cosmossdk.io/log doesn't support Go 1.24 yet.

@julienrbrt
Copy link
Member Author

We can go further after bytedance/sonic#741

julienrbrt added a commit that referenced this pull request Feb 17, 2025
@julienrbrt
pin 1.23 to ci (ref #4509)
7066f56
julienrbrt added a commit that referenced this pull request Feb 17, 2025
@julienrbrt
feat(services): add faucet fee config (#4513)
4abea76 
* feat(services): add faucet fee config

* cl

* pin 1.23 to ci (ref #4509)

* fix
mergify bot pushed a commit that referenced this pull request Feb 17, 2025
@julienrbrt @mergify
feat(services): add faucet fee config (#4513)
54f07a5 
* feat(services): add faucet fee config

* cl

* pin 1.23 to ci (ref #4509)

* fix

(cherry picked from commit 4abea76)

# Conflicts:
#	ignite/config/chain/base/config.go
julienrbrt added a commit that referenced this pull request Feb 17, 2025
@mergify @julienrbrt
feat(services): add faucet fee config (backport #4513) (#4514)
e049a22 
* feat(services): add faucet fee config (#4513)

* feat(services): add faucet fee config

* cl

* pin 1.23 to ci (ref #4509)

* fix

(cherry picked from commit 4abea76)

# Conflicts:
#	ignite/config/chain/base/config.go

* conflict

---------

Co-authored-by: Julien Robert <julien@rbrt.fr>
This was referenced Feb 18, 2025
Merged
Merged
@github-actions github-actions bot added component:cmd type:services Service-related issues. labels Feb 26, 2025
@julienrbrt julienrbrt mentioned this pull request Feb 26, 2025
Merged
@Pantani
Copy link
Collaborator

Pantani commented Feb 26, 2025

all CI is falling

@Pantani Pantani self-requested a review February 26, 2025 07:12
@julienrbrt
Copy link
Member Author

Yes, didn't mean to open it

@mergify mergify bot mentioned this pull request Feb 26, 2025
Merged
@julienrbrt julienrbrt marked this pull request as draft February 26, 2025 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilgooz ilgooz Awaiting requested review from ilgooz ilgooz is a code owner

@jeronimoalbi jeronimoalbi Awaiting requested review from jeronimoalbi jeronimoalbi is a code owner

@Pantani Pantani Awaiting requested review from Pantani Pantani is a code owner

Assignees

@julienrbrt julienrbrt

Labels
component:ci CI/CD workflow and automated jobs. component:cmd component:configs component:templates skip-changelog Don't check changelog for new entries type:internal type:services Service-related issues.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@julienrbrt @Pantani