Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separating free lots request from evcs power calculation #26

Closed
wants to merge 2 commits into from

Conversation

sebastian-peter
Copy link
Member

Resolves #19

@codecov
Copy link

codecov bot commented Dec 13, 2021

Codecov Report

Merging #26 (ba51c13) into dev (8cd28f9) will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev      #26      +/-   ##
==========================================
- Coverage   79.32%   79.30%   -0.03%     
==========================================
  Files         155      155              
  Lines        5746     5745       -1     
  Branches       80       80              
==========================================
- Hits         4558     4556       -2     
- Misses       1188     1189       +1     
Impacted Files Coverage Δ
...c/main/scala/edu/ie3/simona/agent/ValueStore.scala 83.33% <0.00%> (-7.58%) ⬇️
...a/edu/ie3/simona/service/ev/ExtEvDataService.scala 89.87% <0.00%> (-0.38%) ⬇️
...agent/participant/evcs/EvcsAgentFundamentals.scala 87.17% <0.00%> (-0.33%) ⬇️
.../ie3/simona/agent/participant/evcs/EvcsAgent.scala 77.77% <0.00%> (+11.11%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8cd28f9...ba51c13. Read the comment docs.

Copy link
Member

@ckittl ckittl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general looks good to me! There are only two minor remarks.

However, we currently don't have any kind of Changelog and it would be sad, if we would loose all that kind of documentation. Maybe we can start a draft changelog, that is then consolidated, when there is the first release (cf. https://github.com/ie3-institute/simona/blob/ba6281214d8f2a7b7c1060cd6783cd03f822fc1f/CHANGELOG.md)?

@sebastian-peter
Copy link
Member Author

@ckittl thanks for the review. I addressed your comments and will add missing tests as well

@sebastian-peter
Copy link
Member Author

sebastian-peter commented Dec 13, 2021

I have to close this one as well, as it's still linking to the old branch name. New PR at #30

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move parking lot request out of calculatePowerWithSecondaryDataAndGoToIdle
2 participants