Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move parking lot request out of calculatePowerWithSecondaryDataAndGoToIdle #19

Closed
sebastian-peter opened this issue Dec 13, 2021 · 0 comments · Fixed by #30
Closed

Move parking lot request out of calculatePowerWithSecondaryDataAndGoToIdle #19

sebastian-peter opened this issue Dec 13, 2021 · 0 comments · Fixed by #30
Assignees
@sebastian-peter
Labels
code quality Code readability or efficiency is improved

Comments

@sebastian-peter
Copy link
Member

Currently, EvFreeLotsRequest are handled within calculatePowerWithSecondaryDataAndGoToIdle of EvcsAgentFundamentals.

Free lot requests should be handled inside its own method.
@sebastian-peter sebastian-peter self-assigned this Dec 13, 2021
This was referenced Dec 13, 2021
Closed
Merged
@sebastian-peter sebastian-peter added the code quality Code readability or efficiency is improved label Dec 14, 2021
sebastian-peter added a commit that referenced this issue Jan 3, 2022
@sebastian-peter
Merge branch 'dev' into sp/#19-separate-lots-request
da7e74c
sebastian-peter added a commit that referenced this issue Jan 10, 2022
@sebastian-peter
Merge branch 'dev' into sp/#19-separate-lots-request
787c491
ckittl pushed a commit that referenced this issue Jan 11, 2022
@sebastian-peter
Separating free lots request from evcs power calculation
a779d00 
* Addressing review comments

* Enhancing ValueStore test

* Enhanced tests for ExtEvdataService

* Fixed changelog to adhere to format

* Merge branch 'dev' into sp/#19-separate-lots-request

* Merge branch 'dev' into sp/#19-separate-lots-request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sebastian-peter sebastian-peter

Labels
code quality Code readability or efficiency is improved
Projects
None yet
Milestone
No milestone
1 participant
@sebastian-peter