fix: menu not highlighted while navigating via url fixed -2 #316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
onfranciis
approved these changes
Aug 20, 2023
Ando22
reviewed
Aug 20, 2023
| <Link to={'/'} /> | ||
| Dashboard | ||
| </Menu.Item> | ||
| <Menu.Item key={'Customer'} icon={<CustomerServiceOutlined />}> | ||
| <Menu.Item key={'/customer'} icon={<CustomerServiceOutlined />}> |
There was a problem hiding this comment.
Instead of doing this, iterate the component and create a static array object constant that holds the key and the icon. so it will be easier to scale and reuse the component
There was a problem hiding this comment.
Ok changes done as requested, please review
salahlalami
approved these changes
Aug 21, 2023
awesomedev82
pushed a commit
to awesomedev82/idurar-erp-crm
that referenced
this pull request
May 20, 2024
…ot-highlighted-2 fix: menu not highlighted while navigating via url fixed -2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Corrected the issue #306 where the menu is not being highlighted if the page is visited by changing the url. Raising pr again as per request
Corrected.Issue.of.Menu.Highlighting.Demo.mov