Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix:corrected issue #306:the menu is not highlighted #309

Conversation

ashmeetsmonga
Copy link
Contributor

Corrected the issue #306 where the menu is not being highlighted if the page is visited by changing the url

Corrected.Issue.of.Menu.Highlighting.Demo.mov

@ghost
Copy link

ghost commented Aug 16, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

Copy link
Collaborator

@polymahh polymahh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i wanted to remove yarn.lock and package-lock.jason , but i did a mistake now it will be removed from the project 👎
can you fix it and remove packaje.json and yarn.lock from the PR we only need the navigation file

@ashmeetsmonga
Copy link
Contributor Author

ashmeetsmonga commented Aug 18, 2023

Corrected @polymahh. I don't know why now it is showing change in yarn.lock (the same line is being shown as removed and added).

@polymahh polymahh linked an issue Aug 18, 2023 that may be closed by this pull request
@polymahh
Copy link
Collaborator

@ashmeetsmonga sorry i think my commit is what made it stick ... if there is no way to fix it just close this PR and create a new branch from dev and copy your code it is going to be easier... i already tested your code

@ashmeetsmonga
Copy link
Contributor Author

@polymahh new pr #316 raised. Closing this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

the menu is not highlighted
2 participants