Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#105 memory leaks #106

Merged
merged 61 commits into from
Mar 20, 2021
Merged

#105 memory leaks #106

merged 61 commits into from
Mar 20, 2021

Conversation

Alex009
Copy link
Member

@Alex009 Alex009 commented Feb 18, 2021

No description provided.

Alex009 added 29 commits February 17, 2021 00:14
@Alex009
#105 gradle 6.8.2
c4f8f06
@Alex009
#105 add autobuild in podfile
75120b4
@Alex009
#105 shared scheme with profiling
0ab0937
@Alex009
#105 add garbage collector funcs in sample
a75ee6e
@Alex009
#105 fix ios UIControl leaks
163cdf6
@Alex009
#105 suppress warning
ab36b14
@Alex009
#105 add weak reference class
f21f298
@Alex009
#105 update to kotlin 1.4.30
039f658
@Alex009
#105 flatmap tests
346b33e
@Alex009
#105 pretty tests code
73b5f54
@Alex009
#105 cleanup tests code
f560671
@Alex009
#105 map new tests cases
07c4c54
@Alex009
#105 add mapTrueOrNull test
6c69f5b
@Alex009
#105 fix test naming
6e2e367
@Alex009
#105 fix message
c25752a
@Alex009
#105 revert test
2a9cabd
@Alex009
#105 required test
23c1b2a
@Alex009
#105 orEmpty test
fd8a4cf
@Alex009
#105 List orEmpty test
697c8c9
@Alex009
#105 mapBuffered test
2ffad70
@Alex009
#105 fix detekt
391026c
@Alex009
#105 fix test name for windows
b2b2a8a
@Alex009
#105 flatMapBuffered test
df025e8
@Alex009
#105 mediator test rework
f9e45ec
@Alex009
#105 mediator compose test
531c850
@Alex009
#105 composition test
96c22d1
@Alex009
#105 mediator extension test
d975fa5
@Alex009
#105 all extension test
946c067
@Alex009
#105 implemented lifecycle observing on iOS side
86d2ecf
@Alex009
Copy link
Member Author

Alex009 commented Mar 5, 2021

moko-mvvm/mvvm-livedata/src/commonMain/kotlin/dev/icerock/moko/mvvm/livedata/LiveDataCoroutines.kt

Line 25 in a20006e

fun <T> Flow<T>.asLiveData(coroutineScope: CoroutineScope, initialValue: T): LiveData<T> {
here should be on active/inactive

@Alex009 Alex009 mentioned this pull request Mar 15, 2021
Open
@Alex009 Alex009 modified the milestones: 0.9.2, 0.10.0 Mar 16, 2021
@Alex009 Alex009 linked an issue Mar 16, 2021 that may be closed by this pull request
Add Closable into result of LiveData.bind methods to close opened subscriptions #107
Closed
@Alex009 Alex009 marked this pull request as ready for review March 16, 2021 05:02
@Alex009 Alex009 requested a review from Dorofeev March 18, 2021 08:02
@Alex009 Alex009 merged commit 5849e93 into develop Mar 20, 2021
@Alex009 Alex009 deleted the #105-memory-leaks branch March 20, 2021 12:05
@Alex009 Alex009 modified the milestones: 0.10.0, 0.11.0 Apr 6, 2021
@Alex009 Alex009 removed this from the 0.11.0 milestone Jun 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dorofeev Dorofeev Dorofeev approved these changes

Assignees

@Alex009 Alex009

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ios memory leaks Add Closable into result of LiveData.bind methods to close opened subscriptions
2 participants
@Alex009 @Dorofeev