Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Closable into result of LiveData.bind methods to close opened subscriptions #107

Closed
Alex009 opened this issue Feb 18, 2021 · 0 comments · Fixed by #106
Closed

Add Closable into result of LiveData.bind methods to close opened subscriptions #107

Alex009 opened this issue Feb 18, 2021 · 0 comments · Fixed by #106
Assignees
@Alex009
Labels
enhancement New feature or request
Milestone
0.10.0

Comments

@Alex009
Copy link
Member

Alex009 commented Feb 18, 2021

now all bind methods only add observers, but we need also to removeObserver (unbind view from livedata) - result with Closable type can be good for this
@Alex009 Alex009 added the enhancement New feature or request label Feb 18, 2021
@Alex009 Alex009 self-assigned this Mar 11, 2021
@Alex009 Alex009 added this to the 0.10.0 milestone Mar 16, 2021
@Alex009 Alex009 linked a pull request Mar 16, 2021 that will close this issue
#105 memory leaks #106
Merged
@Alex009 Alex009 closed this as completed Mar 20, 2021
Alex009 added a commit that referenced this issue Mar 24, 2021
@Alex009
#107 fix crash on iOS with fun interface
5ae2ac6
@Alex009 Alex009 mentioned this issue Mar 24, 2021
Closed
3 tasks
Alex009 added a commit that referenced this issue Mar 25, 2021
@Alex009
#107 fix format
02d11ea
Alex009 added a commit that referenced this issue Mar 25, 2021
@Alex009
#107 update abi
2aebe5b
Alex009 added a commit that referenced this issue Mar 25, 2021
@Alex009
Merge pull request #118 from icerockdev/#107-fix-ios-crash
6bce9af 
#107 fix crash on iOS with fun interface
@Alex009 Alex009 modified the milestones: 0.10.0, 0.11.0 Apr 6, 2021
@Dorofeev Dorofeev mentioned this issue Apr 30, 2021
Merged
@Alex009 Alex009 modified the milestones: 0.11.0, 0.10.0 Jun 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Alex009 Alex009

Labels
enhancement New feature or request
Projects
None yet
Milestone
0.10.0
Development

Successfully merging a pull request may close this issue.

#105 memory leaks icerockdev/moko-mvvm
1 participant
@Alex009