fix(sensor-controller): Return err when a sensor spec is invalid. Fixes

argoproj#1017 (argoproj#1018) Signed-off-by: Derek Wang <whynowy@gmail.com>
icecoffee531 · Jan 19, 2021 · f9d2cc0 · f9d2cc0
1 parent d3673d8
commit f9d2cc0
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 1 deletion.
diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml
@@ -6,7 +6,6 @@ on:
       - 'v*'
     branches:
       - master
-      - quay-test
 
 jobs:
   release:

diff --git a/controllers/sensor/controller.go b/controllers/sensor/controller.go
@@ -91,6 +91,7 @@ func (r *reconciler) reconcile(ctx context.Context, sensor *v1alpha1.Sensor) err
 	err := ValidateSensor(sensor)
 	if err != nil {
 		log.Errorw("validation error", "error", err)
+		return err
 	}
 	args := &AdaptorArgs{
 		Image:  r.sensorImage,